This is great. Just one little fix needed.
https://codereview.chromium.org/1226143009/diff/20001/src/string.js
File src/string.js (right):
https://codereview.chromium.org/1226143009/diff/20001/src/string.js#newcode612
src/string.js:612: limit = IS_UNDEFINED(limit) ?
GlobalNumber.MAX_SAFE_INTEGER
Defined this way, a user could modify Number.MAX_SAFE_INTEGER and change
the behavior of String.prototype.split, which violates the spec.
Instead, you can copy that value into another variable, so that it's
evaluated at bootstrap time before a user messes everything up.
https://codereview.chromium.org/1226143009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
