Revision: 3734
Author: [email protected]
Date: Thu Jan 28 04:41:27 2010
Log: Move a line, in codegen-*.cc. Make formatting of ic-*.cc uniform.
Review URL: http://codereview.chromium.org/552210
http://code.google.com/p/v8/source/detail?r=3734
Modified:
/branches/bleeding_edge/src/arm/codegen-arm.cc
/branches/bleeding_edge/src/arm/ic-arm.cc
/branches/bleeding_edge/src/ia32/codegen-ia32.cc
/branches/bleeding_edge/src/ia32/ic-ia32.cc
/branches/bleeding_edge/src/x64/codegen-x64.cc
/branches/bleeding_edge/src/x64/ic-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/codegen-arm.cc Thu Jan 28 00:14:19 2010
+++ /branches/bleeding_edge/src/arm/codegen-arm.cc Thu Jan 28 04:41:27 2010
@@ -4377,6 +4377,7 @@
Comment cmnt(masm, "[ Store to Slot");
Slot* slot = expression_->AsVariableProxy()->AsVariable()->slot();
cgen_->StoreToSlot(slot, init_state);
+ cgen_->UnloadReference(this);
break;
}
@@ -4398,6 +4399,7 @@
&property_name,
0);
frame->EmitPush(r0);
+ cgen_->UnloadReference(this);
break;
}
@@ -4414,13 +4416,13 @@
frame->EmitPop(r0); // value
frame->CallCodeObject(ic, RelocInfo::CODE_TARGET, &value, 0);
frame->EmitPush(r0);
+ cgen_->UnloadReference(this);
break;
}
default:
UNREACHABLE();
}
- cgen_->UnloadReference(this);
}
=======================================
--- /branches/bleeding_edge/src/arm/ic-arm.cc Fri Jan 22 05:56:12 2010
+++ /branches/bleeding_edge/src/arm/ic-arm.cc Thu Jan 28 04:41:27 2010
@@ -170,7 +170,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
Label miss;
__ ldr(r0, MemOperand(sp, 0));
@@ -204,7 +203,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
Label miss;
// Load receiver.
@@ -318,7 +316,6 @@
// ----------- S t a t e -------------
// -- lr: return address
// -----------------------------------
-
Label miss, global_object, non_global_object;
// Get the receiver of the function from the stack into r1.
@@ -451,7 +448,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
Label miss, probe, global;
__ ldr(r0, MemOperand(sp, 0));
@@ -543,6 +539,8 @@
// -- lr : return address
// -- sp[0] : key
// -- sp[4] : receiver
+ // -----------------------------------
+
__ ldm(ia, sp, r2.bit() | r3.bit());
__ stm(db_w, sp, r2.bit() | r3.bit());
@@ -555,6 +553,7 @@
// -- lr : return address
// -- sp[0] : key
// -- sp[4] : receiver
+ // -----------------------------------
Label slow, fast;
// Get the key and receiver object from the stack.
@@ -622,6 +621,8 @@
// -- lr : return address
// -- sp[0] : key
// -- sp[4] : receiver
+ // -----------------------------------
+
GenerateGeneric(masm);
}
@@ -640,6 +641,7 @@
// -- lr : return address
// -- sp[0] : key
// -- sp[1] : receiver
+ // -----------------------------------
__ ldm(ia, sp, r2.bit() | r3.bit());
__ stm(db_w, sp, r0.bit() | r2.bit() | r3.bit());
@@ -654,7 +656,9 @@
// -- lr : return address
// -- sp[0] : key
// -- sp[1] : receiver
+ // -----------------------------------
Label slow, fast, array, extra, exit;
+
// Get the key and the object from the stack.
__ ldm(ia, sp, r1.bit() | r3.bit()); // r1 = key, r3 = receiver
// Check that the key is a smi.
=======================================
--- /branches/bleeding_edge/src/ia32/codegen-ia32.cc Wed Jan 27 06:07:12
2010
+++ /branches/bleeding_edge/src/ia32/codegen-ia32.cc Thu Jan 28 04:41:27
2010
@@ -6704,6 +6704,7 @@
Slot* slot = expression_->AsVariableProxy()->AsVariable()->slot();
ASSERT(slot != NULL);
cgen_->StoreToSlot(slot, init_state);
+ cgen_->UnloadReference(this);
break;
}
@@ -6712,6 +6713,7 @@
cgen_->frame()->Push(GetName());
Result answer = cgen_->frame()->CallStoreIC();
cgen_->frame()->Push(&answer);
+ cgen_->UnloadReference(this);
break;
}
@@ -6814,13 +6816,13 @@
__ nop();
cgen_->frame()->Push(&answer);
}
+ cgen_->UnloadReference(this);
break;
}
default:
UNREACHABLE();
}
- cgen_->UnloadReference(this);
}
=======================================
--- /branches/bleeding_edge/src/ia32/ic-ia32.cc Fri Jan 22 05:56:12 2010
+++ /branches/bleeding_edge/src/ia32/ic-ia32.cc Thu Jan 28 04:41:27 2010
@@ -180,7 +180,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
Label miss;
__ mov(eax, Operand(esp, kPointerSize));
@@ -197,7 +196,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
Label miss;
__ mov(eax, Operand(esp, kPointerSize));
@@ -214,7 +212,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
Label miss;
__ mov(eax, Operand(esp, kPointerSize));
@@ -1039,7 +1036,6 @@
// -- ...
// -- esp[(argc + 1) * 4] : receiver
// -----------------------------------
-
Label miss, global_object, non_global_object;
// Get the receiver of the function from the stack; 1 ~ return address.
@@ -1178,7 +1174,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
Label miss, probe, global;
__ mov(eax, Operand(esp, kPointerSize));
@@ -1428,7 +1423,6 @@
// -- esp[4] : receiver
// -----------------------------------
- // Move the return address below the arguments.
__ pop(ebx);
__ push(Operand(esp, 0));
__ push(ecx);
@@ -1451,7 +1445,6 @@
// -- esp[8] : receiver
// -----------------------------------
- // Move the return address below the arguments.
__ pop(ecx);
__ push(Operand(esp, 1 * kPointerSize));
__ push(Operand(esp, 1 * kPointerSize));
@@ -1472,7 +1465,6 @@
// -- esp[8] : receiver
// -----------------------------------
- // Move the return address below the arguments.
__ pop(ebx);
__ push(Operand(esp, 1 * kPointerSize));
__ push(ecx);
=======================================
--- /branches/bleeding_edge/src/x64/codegen-x64.cc Wed Jan 27 06:07:12 2010
+++ /branches/bleeding_edge/src/x64/codegen-x64.cc Thu Jan 28 04:41:27 2010
@@ -6009,6 +6009,7 @@
Slot* slot = expression_->AsVariableProxy()->AsVariable()->slot();
ASSERT(slot != NULL);
cgen_->StoreToSlot(slot, init_state);
+ cgen_->UnloadReference(this);
break;
}
@@ -6017,6 +6018,7 @@
cgen_->frame()->Push(GetName());
Result answer = cgen_->frame()->CallStoreIC();
cgen_->frame()->Push(&answer);
+ cgen_->UnloadReference(this);
break;
}
@@ -6118,13 +6120,13 @@
masm->nop();
cgen_->frame()->Push(&answer);
}
+ cgen_->UnloadReference(this);
break;
}
default:
UNREACHABLE();
}
- cgen_->UnloadReference(this);
}
=======================================
--- /branches/bleeding_edge/src/x64/ic-x64.cc Fri Jan 22 05:56:12 2010
+++ /branches/bleeding_edge/src/x64/ic-x64.cc Thu Jan 28 04:41:27 2010
@@ -414,6 +414,7 @@
// -- rsp[8] : name
// -- rsp[16] : receiver
// -----------------------------------
+
GenerateGeneric(masm);
}
@@ -1080,7 +1081,6 @@
// rsp[(argc + 1) * 8] argument 0 = receiver
// rsp[(argc + 2) * 8] function name
// -----------------------------------
-
Label miss, global_object, non_global_object;
// Get the receiver of the function from the stack.
@@ -1178,7 +1178,6 @@
// -- rsp[0] : return address
// -- rsp[8] : receiver
// -----------------------------------
-
Label miss;
__ movq(rax, Operand(rsp, kPointerSize));
@@ -1195,7 +1194,6 @@
// -- rsp[0] : return address
// -- rsp[8] : receiver
// -----------------------------------
-
Label miss;
__ movq(rax, Operand(rsp, kPointerSize));
@@ -1243,7 +1241,6 @@
// -- rsp[0] : return address
// -- rsp[8] : receiver
// -----------------------------------
-
Label miss, probe, global;
__ movq(rax, Operand(rsp, kPointerSize));
@@ -1291,7 +1288,6 @@
// -- rsp[0] : return address
// -- rsp[8] : receiver
// -----------------------------------
-
Label miss;
__ movq(rax, Operand(rsp, kPointerSize));
@@ -1337,6 +1333,7 @@
// -- rsp[0] : return address
// -- rsp[8] : receiver
// -----------------------------------
+
__ pop(rbx);
__ push(Operand(rsp, 0)); // receiver
__ push(rcx); // name
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
