Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Debugger: record reloc info for debug break slot immediate before the
slot.
port 0a19e44925301b9c0a554bbec5e3fb5a6cd09efa (r29568)
original commit message:
If we do it too early, we might get a constant pool between the reloc
info
and the actual slot.
Please review this at https://codereview.chromium.org/1228923003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -1 lines):
M src/x87/debug-x87.cc
Index: src/x87/debug-x87.cc
diff --git a/src/x87/debug-x87.cc b/src/x87/debug-x87.cc
index
c7ef01ee6fa00281b9c8f34c2f413fedbd11a7f9..3b1800f1607e17c16d1dd8a47f0006afc127934d
100644
--- a/src/x87/debug-x87.cc
+++ b/src/x87/debug-x87.cc
@@ -157,10 +157,13 @@ void
DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
}
-void DebugCodegen::GenerateSlot(MacroAssembler* masm) {
+void DebugCodegen::GenerateSlot(MacroAssembler* masm,
+ DebugCodegen::SlotLocation location,
+ int call_argc) {
// Generate enough nop's to make space for a call instruction.
Label check_codesize;
__ bind(&check_codesize);
+ RecordRelocInfo(masm, location, call_argc);
__ Nop(Assembler::kDebugBreakSlotLength);
DCHECK_EQ(Assembler::kDebugBreakSlotLength,
masm->SizeOfCodeGeneratedSince(&check_codesize));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
