On 2015/07/13 19:35:24, Michael Starzinger wrote:
LGTM.
https://codereview.chromium.org/1235603002/diff/30001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/1235603002/diff/30001/src/debug.cc#newcode1452
src/debug.cc:1452: delta = old_pc - current_pc;
This assumes that for each call site the size is the same in debug as
well as
in
non-debug code. Does this hold?
That holds. The call site in debug code is the same as in non-debug code.
The
only difference is that the debug code contains a debug break slot *before*
the
call. I calculate the delta so that I don't have to introduce a call
instruction
length constant for each platform.
https://codereview.chromium.org/1235603002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
