https://codereview.chromium.org/1234833003/diff/20001/src/ia32/assembler-ia32-inl.h
File src/ia32/assembler-ia32-inl.h (right):
https://codereview.chromium.org/1234833003/diff/20001/src/ia32/assembler-ia32-inl.h#newcode78
src/ia32/assembler-ia32-inl.h:78: return;
On 2015/07/14 09:12:45, ulan wrote:
I think it is cleaner to just set flush_icache to false.
apply is only ever called with SKIP_ICACHE_FLUSH. So I'm going to remove
this parameter and make this simpler. I added a comment to the function
declaration.
Also icache_flush_mode is not even honored on ARM and ARM64.
https://codereview.chromium.org/1234833003/diff/20001/src/liveedit.cc
File src/liveedit.cc (left):
https://codereview.chromium.org/1234833003/diff/20001/src/liveedit.cc#oldcode1191
src/liveedit.cc:1191: if (shared_info->debug_info()->IsDebugInfo()) {
On 2015/07/14 09:12:45, ulan wrote:
DCHECK(shared_info->debug_info()->IsDebugInfo()) ?
Since we don't keep a copy of the original code anymore, we don't have
to keep it updated. So here we simply don't care whether we have debug
info.
https://codereview.chromium.org/1234833003/diff/20001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1234833003/diff/20001/src/runtime/runtime-debug.cc#newcode1399
src/runtime/runtime-debug.cc:1399: if (!ignore_nested_scopes &&
!shared_info->debug_info()->IsUndefined()) {
On 2015/07/14 09:12:45, ulan wrote:
What happens if there is no debug info?
We can only ever end up here from a return statement if we set a break
point at the return statement, which requires a debug info to exist. I
updated the comment to better reflect this.
https://codereview.chromium.org/1234833003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
