Status: Assigned
Owner: [email protected]
Labels: Type-FeatureRequest Priority-Medium
New issue 4301 by [email protected]: Fix race in merge_to_branch for
simultaneous merge processes
https://code.google.com/p/v8/issues/detail?id=4301
Currently, if two people call merge_to_branch, the following race can occur:
1. Current V8 version is X
2. A starts merging and waits for LGTM (script creates a CL for version X+1)
3. B starts merging and waits for LGTM (script creates a CL for version X+1)
4. A gets LGTM, commits and tags version X+1
5. B gets LGTM, commits version X+1 and then gets a tag failure as a tag
for version X+1 already exists.
Suggested workaround:
Let step 5 fail before committing. The merge needs to be restarted from
scratch, but in the end we'd have correct versions.
Suggested real fix:
- Upload a CL which is version-independent (i.e. only contains the patches
and also has a version-independent title).
- After LGTM, make the version change locally, right before pushing, and
compute the commit message based on the current version on the HEAD of the
branch.
(of course a race can still occur, but the window for that'd be very small)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
