ARM and ARM64 looks sensible. Minor comments only.
I won't be in the office tomorrow so I've put Rodolph on the list in case
you
want another ARM review.
https://codereview.chromium.org/1237813002/diff/20001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/1237813002/diff/20001/src/arm/code-stubs-arm.cc#newcode2622
src/arm/code-stubs-arm.cc:2622: __ push(r4);
On 2015/07/14 15:02:47, Michael Starzinger wrote:
Potentially applies to all architectures: Note that I realize that on
some
architectures we could probably avoid this push and the pop a few
lines below,
by massaging GenerateRecordCallTarget appropriately so that it
preserves the
register in question. However I would like to do this in a follow-up
CL if
possible. But I am of course happy to leave a TODO for all
architectures where
this might apply, just let me know.
A TODO is probably a good idea, but it's up to you. On ARM64,
GenerateRecordCallTarget takes a list of scratch registers, and that
approach works quite well.
https://codereview.chromium.org/1237813002/diff/20001/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):
https://codereview.chromium.org/1237813002/diff/20001/src/arm64/code-stubs-arm64.cc#newcode3004
src/arm64/code-stubs-arm64.cc:3004: GenerateRecordCallTarget(masm, x0,
function, x2, x3, x4, x5, x11);
ARM64's GenerateRecordCallTarget allows the scratch registers to be
specified, so it should be possible to just specify something other than
x4 and skip the push/pop sequence.
https://codereview.chromium.org/1237813002/diff/20001/src/arm64/full-codegen-arm64.cc
File src/arm64/full-codegen-arm64.cc (right):
https://codereview.chromium.org/1237813002/diff/20001/src/arm64/full-codegen-arm64.cc#newcode3093
src/arm64/full-codegen-arm64.cc:3093: __ mov(x4, result_register());
We prefer the MacroAssembler's "__ Mov(...)" in ARM64, for consistency,
even though it doesn't make any difference in this particular case. (The
lower-case Assembler versions are usually reserved for critical sections
in InstructionAccurateScopes.)
https://codereview.chromium.org/1237813002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
