Reviewers: jarin, Michael Achenbach,
Message:
Created Revert of d8 workers: make sure Shell::Quit is only called once
Description:
Revert of d8 workers: make sure Shell::Quit is only called once (patchset #5
id:80001 of https://codereview.chromium.org/1230403003/)
Reason for revert:
Breaks webkit_unit_tests. See
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/853/steps/webkit_unit_tests/logs/stdio
Original issue's description:
d8 workers: make sure Shell::Quit is only called once
When running with isolates, Quit can be called simultaneously by two
threads.
If this happens, then both threads try to clean up the Workers, which
could
crash.
BUG=v8:4279
[email protected]
[email protected]
LOG=n
Committed: https://crrev.com/76184292b392d107609f21662a949b58bb1e258c
Cr-Commit-Position: refs/heads/master@{#29654}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4279
Please review this at https://codereview.chromium.org/1235083004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -15 lines):
M src/d8.h
M src/d8.cc
M test/mjsunit/mjsunit.status
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
