Where are the other callers going to live? My only concern with this is that
utils.h is currently pretty JS-agnostic (which is why I suggested adding
comments pointing to the spec, to make it clear these are for spec
compliance).
https://codereview.chromium.org/1234073003/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1234073003/diff/20001/src/objects.cc#newcode686
src/objects.cc:686: return v8::internal::SameValue(Number(),
other->Number());
Why the "v8::internal::" prefix here? Does this fail to lookup properly
without it?
https://codereview.chromium.org/1234073003/diff/20001/src/utils.h
File src/utils.h (right):
https://codereview.chromium.org/1234073003/diff/20001/src/utils.h#newcode205
src/utils.h:205: bool SameValue(T x, T y) {
Can you add a comment linking to:
http://www.ecma-international.org/ecma-262/6.0/#sec-samevalue
https://codereview.chromium.org/1234073003/diff/20001/src/utils.h#newcode215
src/utils.h:215: bool SameValueZero(T x, T y) {
And here linking to:
http://www.ecma-international.org/ecma-262/6.0/#sec-samevaluezero
https://codereview.chromium.org/1234073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
