code l-g-t-m, some nits in the comments :-)
https://codereview.chromium.org/1233213002/diff/1/src/mips/assembler-mips-inl.h
File src/mips/assembler-mips-inl.h (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips/assembler-mips-inl.h#newcode369
src/mips/assembler-mips-inl.h:369: // debug-mips.cc
BreakLocation::SetDebugBreakAtReturn(), or
comment nit: remove mention of deleted function
BreakLocation::SetDebugBreakAtReturn()
https://codereview.chromium.org/1233213002/diff/1/src/mips/debug-mips.cc
File src/mips/debug-mips.cc (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips/debug-mips.cc#newcode34
src/mips/debug-mips.cc:34: // the constant pool in the debug break slot
code.
nit: constant pool -> trampoline pool
https://codereview.chromium.org/1233213002/diff/1/src/mips64/assembler-mips64-inl.h
File src/mips64/assembler-mips64-inl.h (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips64/assembler-mips64-inl.h#newcode360
src/mips64/assembler-mips64-inl.h:360: // debug break slot per
BreakLocation::SetDebugBreakAtSlot().
comment nit: remove ref to removed function SetDebugBreakAtReturn()
https://codereview.chromium.org/1233213002/diff/1/src/mips64/debug-mips64.cc
File src/mips64/debug-mips64.cc (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips64/debug-mips64.cc#newcode33
src/mips64/debug-mips64.cc:33: // the constant pool in the debug break
slot code.
comment nit: 'constant' -> trampoline
https://codereview.chromium.org/1233213002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
