Reviewers: paul.l...,
https://codereview.chromium.org/1233213002/diff/1/src/mips/assembler-mips-inl.h
File src/mips/assembler-mips-inl.h (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips/assembler-mips-inl.h#newcode369
src/mips/assembler-mips-inl.h:369: // debug-mips.cc
BreakLocation::SetDebugBreakAtReturn(), or
On 2015/07/14 19:15:59, paul.l... wrote:
comment nit: remove mention of deleted function
BreakLocation::SetDebugBreakAtReturn()
Done.
https://codereview.chromium.org/1233213002/diff/1/src/mips/debug-mips.cc
File src/mips/debug-mips.cc (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips/debug-mips.cc#newcode34
src/mips/debug-mips.cc:34: // the constant pool in the debug break slot
code.
On 2015/07/14 19:15:59, paul.l... wrote:
nit: constant pool -> trampoline pool
Done.
https://codereview.chromium.org/1233213002/diff/1/src/mips64/assembler-mips64-inl.h
File src/mips64/assembler-mips64-inl.h (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips64/assembler-mips64-inl.h#newcode360
src/mips64/assembler-mips64-inl.h:360: // debug break slot per
BreakLocation::SetDebugBreakAtSlot().
On 2015/07/14 19:15:59, paul.l... wrote:
comment nit: remove ref to removed function SetDebugBreakAtReturn()
Done.
https://codereview.chromium.org/1233213002/diff/1/src/mips64/debug-mips64.cc
File src/mips64/debug-mips64.cc (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips64/debug-mips64.cc#newcode33
src/mips64/debug-mips64.cc:33: // the constant pool in the debug break
slot code.
On 2015/07/14 19:15:59, paul.l... wrote:
comment nit: 'constant' -> trampoline
Done.
Description:
MIPS: Debugger: use debug break slots to break at function exit.
By not having to patch the return sequence (we patch the debug
break slot right before it), we don't overwrite it and therefore
don't have to keep the original copy of the code around.
BUG=v8:4269
LOG=N
Please review this at https://codereview.chromium.org/1233213002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+112, -332 lines):
M src/mips/assembler-mips.h
M src/mips/assembler-mips.cc
M src/mips/assembler-mips-inl.h
M src/mips/debug-mips.cc
M src/mips/full-codegen-mips.cc
M src/mips64/assembler-mips64.h
M src/mips64/assembler-mips64.cc
M src/mips64/assembler-mips64-inl.h
M src/mips64/debug-mips64.cc
M src/mips64/full-codegen-mips64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
