Reviewers: jochen,
Description:
Deprecate unused Map/Set FromArray factory methods
These were added when I thought they would be useful in Blink, but as
it turned out they were not. They could likely be deleted immediately,
but to play it safe I'll go through the usual deprecation process.
Please review this at https://codereview.chromium.org/1236263004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -4 lines):
M include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
560bfb4d00370d5edaf2ab34c4e4e8e8a7369ebf..92a1235e672a182600228124b94fe2d5a4204ae2
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3008,8 +3008,9 @@ class V8_EXPORT Map : public Object {
* in the same manner as the array returned from AsArray().
* Guaranteed to be side-effect free if the array contains no holes.
*/
- static V8_WARN_UNUSED_RESULT MaybeLocal<Map> FromArray(Local<Context>
context,
- Local<Array>
array);
+ static V8_WARN_UNUSED_RESULT V8_DEPRECATE_SOON(
+ "Use mutation methods instead",
+ MaybeLocal<Map> FromArray(Local<Context> context, Local<Array>
array));
V8_INLINE static Map* Cast(Value* obj);
@@ -3047,8 +3048,9 @@ class V8_EXPORT Set : public Object {
* Creates a new Set containing the items in array.
* Guaranteed to be side-effect free if the array contains no holes.
*/
- static V8_WARN_UNUSED_RESULT MaybeLocal<Set> FromArray(Local<Context>
context,
- Local<Array>
array);
+ static V8_WARN_UNUSED_RESULT V8_DEPRECATE_SOON(
+ "Use mutation methods instead",
+ MaybeLocal<Set> FromArray(Local<Context> context, Local<Array>
array));
V8_INLINE static Set* Cast(Value* obj);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
