Reviewers: rossberg,
Message:
Hi Andreas, here are the changes.
I noticed that in test-parser.cc there are now arrow function tests of the
kind
you proposed, like (eval) => { "use strict"; }, so I didn't need to add
them.
Thanks,
--Michael
Description:
Scoping error caused crash in CallICNexus::StateFromFeedback
A sloppy mode eval call that establishes strict mode will leak that
strictness
into the sloppy surrounding scope on recompile. This changes the structure
of the type feedback vector for the function and crashes follow.
The fix is straightforward.
BUG=491536, 503565
LOG=N
Please review this at https://codereview.chromium.org/1231343003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+107, -57 lines):
M src/parser.h
M src/parser.cc
M src/preparser.h
M src/preparser.cc
A test/mjsunit/regress/regress-491536.js
A test/mjsunit/regress/regress-503565.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
