https://codereview.chromium.org/1228113003/diff/20001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1228113003/diff/20001/src/elements.cc#newcode1655
src/elements.cc:1655: JSObject::RequireSlowElements(object, arguments);
Why not "if (attributes != NONE)" here?
https://codereview.chromium.org/1228113003/diff/20001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/1228113003/diff/20001/src/lookup.cc#newcode321
src/lookup.cc:321: // TODO(verwaest): Remove this hack once we have a
quick way to check the
This TODO does not belong here anymore. Maybe move it to
JSObject::RequireSlowElements().
https://codereview.chromium.org/1228113003/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1228113003/diff/20001/src/objects.cc#newcode14695
src/objects.cc:14695:
GetHeap()->ClearAllICsByKind(Code::KEYED_STORE_IC);
JSObject::RequireSlowElements()?
https://codereview.chromium.org/1228113003/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1228113003/diff/60001/src/objects.cc#newcode4802
src/objects.cc:4802: void JSObject::RequireSlowElements(Handle<JSObject>
obj,
It looks like it does not allocate. Why don't you make it an instance
method?
https://codereview.chromium.org/1228113003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
