LGTM. Trivial comments, but overall this looks great.
https://codereview.chromium.org/1239793002/diff/1/src/compiler/linkage-impl.h
File src/compiler/linkage-impl.h (right):
https://codereview.chromium.org/1239793002/diff/1/src/compiler/linkage-impl.h#newcode243
src/compiler/linkage-impl.h:243: DCHECK_EQ(0,
InterpreterAssembler::kBytecodePointerParameter);
One line comment explaining types purpose (reserving registers).
https://codereview.chromium.org/1239793002/diff/1/src/compiler/linkage.h
File src/compiler/linkage.h (right):
https://codereview.chromium.org/1239793002/diff/1/src/compiler/linkage.h#newcode245
src/compiler/linkage.h:245: bool needs_return);
Suggest a comment on needs_return or a more indicative name (e.g.
function_returns_value).
https://codereview.chromium.org/1239793002/diff/1/src/compiler/raw-machine-assembler.h
File src/compiler/raw-machine-assembler.h (right):
https://codereview.chromium.org/1239793002/diff/1/src/compiler/raw-machine-assembler.h#newcode54
src/compiler/raw-machine-assembler.h:54: CallDescriptor*
call_descriptor);
The two constructors for RawMachineAssembler could be rolled into one,
but adding a default parameter CallDescriptor* call_descriptor = nullptr
to the existing constructor.
https://codereview.chromium.org/1239793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
