Reviewers: rossberg,
Message:
From what I can tell new.target works everywhere (regular functions, arrow
functions, derived class constructors, etc).
Description:
Stage --harmony-new-target
BUG=v8:3887
LOG=y
Please review this at https://codereview.chromium.org/1238693004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -11 lines):
M src/flag-definitions.h
M test/test262-es6/test262-es6.status
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
27c6e0229d17c1845f06b223ed7f8aa63469c97e..f728d20d1e5205be55f5f11ee806ae109a6b6d88
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -196,15 +196,15 @@ DEFINE_BOOL(legacy_const, true, "legacy semantics for
const in sloppy mode")
V(harmony_destructuring, "harmony destructuring") \
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_atomics, "harmony atomics") \
- V(harmony_new_target, "harmony new.target") \
V(harmony_simd, "harmony simd")
// Features that are complete (but still behind --harmony/es-staging flag).
-#define HARMONY_STAGED(V) \
- V(harmony_tostring, "harmony toString") \
- V(harmony_concat_spreadable, "harmony isConcatSpreadable") \
- V(harmony_rest_parameters, "harmony rest parameters") \
- V(harmony_spreadcalls, "harmony spread-calls") \
+#define HARMONY_STAGED(V) \
+ V(harmony_tostring, "harmony toString") \
+ V(harmony_concat_spreadable, "harmony isConcatSpreadable") \
+ V(harmony_new_target, "harmony new.target") \
+ V(harmony_rest_parameters, "harmony rest parameters") \
+ V(harmony_spreadcalls, "harmony spread-calls") \
V(harmony_spread_arrays, "harmony spread in array literals")
// Features that are shipping (turned on by default, but internal flag
remains).
Index: test/test262-es6/test262-es6.status
diff --git a/test/test262-es6/test262-es6.status
b/test/test262-es6/test262-es6.status
index
8a699a094109781e2ec3d8d7697e170ff57bfdc2..782ee39b673e44ca853a6412cc5201f4956e080d
100644
--- a/test/test262-es6/test262-es6.status
+++ b/test/test262-es6/test262-es6.status
@@ -439,11 +439,6 @@
'language/computed-property-names/class/static/method-symbol': [FAIL,
FAIL_SLOPPY],
'language/computed-property-names/class/static/method-string': [FAIL,
FAIL_SLOPPY],
- # new.target
- # https://code.google.com/p/v8/issues/detail?id=3887
- 'language/expressions/arrow-function/lexical-new.target': [FAIL],
- 'language/expressions/arrow-function/lexical-new.target-closure-returned':
[FAIL],
-
# https://code.google.com/p/v8/issues/detail?id=2160
'language/expressions/arrow-function/syntax/arrowparameters-cover-initialize-1':
[FAIL],
'language/expressions/arrow-function/syntax/arrowparameters-cover-initialize-2':
[FAIL],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
