Reviewers: dstence, Michael Achenbach, michael_dawson,
Description:
PPC: Reland Update V8 DEPS.
Port c63e50edc93f0f37b98008fe4012ec3c9479352b
Original commit message:
Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c
Reland after https://codereview.chromium.org/1241643002/
[email protected], [email protected], [email protected]
BUG=
Please review this at https://codereview.chromium.org/1240833002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -8 lines):
M src/ppc/code-stubs-ppc.cc
M src/ppc/full-codegen-ppc.cc
Index: src/ppc/code-stubs-ppc.cc
diff --git a/src/ppc/code-stubs-ppc.cc b/src/ppc/code-stubs-ppc.cc
index
e7c11e7bc621cf2c9e363797f81505f56e405a3d..1d76f6e3d713b10942e1bd46663a5b6012f2ccc5
100644
--- a/src/ppc/code-stubs-ppc.cc
+++ b/src/ppc/code-stubs-ppc.cc
@@ -3190,12 +3190,11 @@ void StringCharCodeAtGenerator::GenerateSlow(
void StringCharFromCodeGenerator::GenerateFast(MacroAssembler* masm) {
// Fast case of Heap::LookupSingleCharacterStringFromCode.
- DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCode + 1));
- __ LoadSmiLiteral(r0, Smi::FromInt(~String::kMaxOneByteCharCode));
+ DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCodeU + 1));
+ __ LoadSmiLiteral(r0, Smi::FromInt(~String::kMaxOneByteCharCodeU));
__ ori(r0, r0, Operand(kSmiTagMask));
- __ and_(r0, code_, r0);
- __ cmpi(r0, Operand::Zero());
- __ bne(&slow_case_);
+ __ and_(r0, code_, r0, SetRC);
+ __ bne(&slow_case_, cr0);
__ LoadRoot(result_, Heap::kSingleCharacterStringCacheRootIndex);
// At this point code register contains smi tagged one-byte char code.
Index: src/ppc/full-codegen-ppc.cc
diff --git a/src/ppc/full-codegen-ppc.cc b/src/ppc/full-codegen-ppc.cc
index
455cc1e3fc7f6ac64e5543452f1b170d3368315d..84446d0946dd365a6bc57615bd2fdd0992f46e36
100644
--- a/src/ppc/full-codegen-ppc.cc
+++ b/src/ppc/full-codegen-ppc.cc
@@ -4463,10 +4463,9 @@ void
FullCodeGenerator::EmitHasCachedArrayIndex(CallRuntime* expr) {
__ lwz(r3, FieldMemOperand(r3, String::kHashFieldOffset));
// PPC - assume ip is free
__ mov(ip, Operand(String::kContainsCachedArrayIndexMask));
- __ and_(r0, r3, ip);
- __ cmpi(r0, Operand::Zero());
+ __ and_(r0, r3, ip, SetRC);
PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
- Split(eq, if_true, if_false, fall_through);
+ Split(eq, if_true, if_false, fall_through, cr0);
context()->Plug(if_true, if_false);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
