http://codereview.chromium.org/543207/diff/9007/8015 File src/codegen.cc (right):
http://codereview.chromium.org/543207/diff/9007/8015#newcode498 src/codegen.cc:498: masm->TailCallRuntime(ExternalReference(f), On 2010/01/29 10:02:12, Søren Gjesse wrote:
I think these parameters can fit on one line.
Done. http://codereview.chromium.org/543207/diff/9007/8012 File src/codegen.h (right): http://codereview.chromium.org/543207/diff/9007/8012#newcode388 src/codegen.h:388: // Markd the debugger statemet to be recognized bu debugger (by the MajorKey) On 2010/01/29 10:02:12, Søren Gjesse wrote:
Markd -> mark
Done. http://codereview.chromium.org/543207/diff/9007/8012#newcode389 src/codegen.h:389: class CEntryDebugBreakStub : public CodeStub { On 2010/01/29 10:02:12, Søren Gjesse wrote:
This is not in itself a C-entry stub. Please rename it to
DebugBreakStub and its
major key to DebugBreak.
As it is only used for the debugger statement calling it
DebuggerStatement would
be more precise and will not cause confusion with other ways to enter
the
debugger.
Maybe introducing new relocation info type and just using a normal
runtime call
could be considered.
Done. http://codereview.chromium.org/543207/diff/9007/8012#newcode397 src/codegen.h:397: int MinorKey() { return 1; } On 2010/01/29 10:02:12, Søren Gjesse wrote:
Use a minor key of 0 as there is only one instance of this stub.
Done. http://codereview.chromium.org/543207/diff/9007/8016 File src/debug.cc (right): http://codereview.chromium.org/543207/diff/9007/8016#newcode80 src/debug.cc:80: debug_break_stub_ = CEntryDebugBreakStub().GetCode(); On 2010/01/29 10:02:12, Søren Gjesse wrote:
As the check is now on the major key the member debug_break_stub_
should not be
needed any more.
Done. http://codereview.chromium.org/543207/diff/9007/8019 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/543207/diff/9007/8019#newcode6983 src/x64/codegen-x64.cc:6983: return (result_size_ < 2) ? 0 : result_size_ * 2; On 2010/01/29 10:02:12, Søren Gjesse wrote:
Does this special assignment of minor key on 64-bit Windows make sense
any more? Probably so (since generated code for WIN64 depends on result_size_). But this line could be simplified since values could not conflict with a descendant class anymore. http://codereview.chromium.org/543207 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
