https://codereview.chromium.org/1234213004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1234213004/diff/1/src/parser.cc#newcode4310
src/parser.cc:4310: bool Parser::NeedsParameterInitializationBlock(
Make this into IsSimpleParameterList, to match what's in the spec. In
particular, it needs to check for rest as well.
https://codereview.chromium.org/1234213004/diff/1/src/parser.cc#newcode4383
src/parser.cc:4383: if (fvar != nullptr) {
Hm, why do you need to move (and duplicate) fvar initialisation and
IsConstruct assert?
https://codereview.chromium.org/1234213004/diff/1/test/mjsunit/strong/destructuring.js
File test/mjsunit/strong/destructuring.js (right):
https://codereview.chromium.org/1234213004/diff/1/test/mjsunit/strong/destructuring.js#newcode10
test/mjsunit/strong/destructuring.js:10: var a = f({ x: undefined });
On 2015/07/15 20:35:44, caitp wrote:
this move kind of makes destructuring initializers not very good, but
maybe this
is actually intentional? Not sure.
Not sure I understand. What's not good?
Btw, language mode vs parameter destructuring is a much bigger problem
than I thought yesterday. Will post something later.
https://codereview.chromium.org/1234213004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
