Reviewers: jochen,
Message:
ptal
Description:
Fix DefineOwnProperty for data properties wrt failed access checks
BUG=chromium:509936
LOG=y
Please review this at https://codereview.chromium.org/1241973003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -1 lines):
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
efe35ed30ecab035dc602df3b821b8f9002fd238..9db2a2fd067c0746d4c1b8fb42754072f51a0699
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4189,7 +4189,9 @@ MaybeHandle<Object>
JSObject::DefineOwnPropertyIgnoreAttributes(
case LookupIterator::ACCESS_CHECK:
if (!it->HasAccess()) {
- return SetPropertyWithFailedAccessCheck(it, value);
+
it->isolate()->ReportFailedAccessCheck(it->GetHolder<JSObject>());
+ RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(it->isolate(), Object);
+ return value;
}
break;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
