minor notes and one question for my education.
http://codereview.chromium.org/553149/diff/2001/2004 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/553149/diff/2001/2004#newcode47 src/arm/fast-codegen-arm.cc:47: __ tst(r1, Operand(kSmiTagMask)); maybe branchonsmi? http://codereview.chromium.org/553149/diff/2001/2004#newcode62 src/arm/fast-codegen-arm.cc:62: // registers are esi (context) and possibly edx (this). Both are also ia32-isms (esi, edx)? http://codereview.chromium.org/553149/diff/2001/2010 File src/fast-codegen.cc (right): http://codereview.chromium.org/553149/diff/2001/2010#newcode523 src/fast-codegen.cc:523: // Result is in eax by convention. eax? http://codereview.chromium.org/553149/diff/2001/2018 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/553149/diff/2001/2018#newcode48 src/x64/fast-codegen-x64.cc:48: __ j(is_smi, bailout()); just for my education: which is preferred, this or JumpIfSmi? http://codereview.chromium.org/553149/diff/2001/2018#newcode61 src/x64/fast-codegen-x64.cc:61: // saved in the stack and esi is preserved by the call. same for esi and edx http://codereview.chromium.org/553149 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
