https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):
https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#newcode392
src/heap/gc-tracer.cc:392: PrintIsolate(heap_->isolate(), "[I:%p] %8.0f
gc-trace: ", heap_->isolate(),
why did you delete the ms?
https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#newcode413
src/heap/gc-tracer.cc:413: case Event::MARK_COMPACTOR:
Here we could further distinguish between incremental marking and
non-incremental marking. But that may not be necessary.
https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#newcode455
src/heap/gc-tracer.cc:455: break;
The default case should never happen:
default:
UNREACHABLE();
https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcode1694
src/heap/heap.cc:1694: ScavengeVisitor scavenge_visitor(this);
This is another interesting event.
https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcode1707
src/heap/heap.cc:1707: // Copy objects reachable from the encountered
weak collections list.
This is another interesting event.
https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcode1723
src/heap/heap.cc:1723: while
(isolate()->global_handles()->IterateObjectGroups(
This is another interesting event.
Let's increase the coverage of the timestamping a bit.
https://codereview.chromium.org/1235913002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
