LGTM!
http://codereview.chromium.org/553149/diff/2001/2010 File src/fast-codegen.cc (right): http://codereview.chromium.org/553149/diff/2001/2010#newcode362 src/fast-codegen.cc:362: full_cgen.Generate(fun, FullCodeGenerator::SECONDARY); Should we also pass the CompilationInfo to the full code generator to propagate loop nesting information, etc.? http://codereview.chromium.org/553149/diff/2001/2010#newcode368 src/fast-codegen.cc:368: Code::Flags flags = Code::ComputeFlags(Code::FUNCTION, NOT_IN_LOOP); (info->loop_nesting() == 0 ? NOT_IN_LOOP : IN_LOOP) instead? http://codereview.chromium.org/553149/diff/2001/2010#newcode537 src/fast-codegen.cc:537: expr->num(), expr->num(), *name_string, expr->value()->num()); As a separate change: It would be nice to emit these as codegen comments, too. http://codereview.chromium.org/553149 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
