Comments addressed. PTAL.
https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes.cc#newcode558
src/runtime/runtime-classes.cc:558:
RUNTIME_ASSERT(reflect->IsJSFunction()); // Depends on
--harmony-reflect.
On 2015/07/20 09:14:39, Michael Starzinger wrote:
On 2015/07/20 09:03:56, Michael Starzinger wrote:
> On 2015/07/17 20:04:01, adamk wrote:
> > --harmony-reflect isn't shipping soon, I think you'll be happier
if you just
> > modify bootstrapper.cc to always put $reflectConstruct on the
builtins.
>
> I think I am confused about what is shipping and what isn't. How can
> Parser::SpreadCall desugar to %ReflectConstruct? Aren't classes with
super
calls
> as well as spread calls shipping?
Oh boy, in Genesis::InitializeGlobal_harmony_reflect we already
explicitly check
for FLAG_harmony_spreadcalls as well. How about we just remove this
hack there
and just always install $reflectApply and $reflectConstruct instead?
Done. I did so on the third patch set.
https://codereview.chromium.org/1240993002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
