Runtime_CollectStackTrace doesn't use StackTraceFrameIterator and is not
affected by this change. I'm not sure if we want to exclude all the frames
with
functions from native scripts. If we want to do so, we could probably use
StackTraceFrameIterator instead of StackFrameIterator in
Runtime_CollectStackTrace. Probably it's not that bad to show builtin
functions
in the stack trace since in the case of stack trace user is still able to
track
the source of error (unlike error message handler where the stack may not
be
available).
On 2010/02/01 09:21:20, Søren Gjesse wrote:
LGTM
Consider adding a test to tets/mjsunit/stack-traces.js as well.
http://codereview.chromium.org/555170
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
