Reviewers: Yang,
Description:
Fix stack trace printing in d8
[email protected]
BUG=chromium:511988
LOG=n
Please review this at https://codereview.chromium.org/1246643002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M src/d8.cc
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
06499ef6dd39efd2c45962a907277f3013b4a6a0..a56d029f5a5fb2fedb3fb568578ca9b90f53bada
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -917,7 +917,8 @@ void Shell::ReportException(Isolate* isolate,
v8::TryCatch* try_catch) {
printf("\n");
Local<Value> stack_trace_string;
if (try_catch->StackTrace(isolate->GetCurrentContext())
- .ToLocal(&stack_trace_string)) {
+ .ToLocal(&stack_trace_string) &&
+ stack_trace_string->IsString()) {
v8::String::Utf8Value stack_trace(
Local<String>::Cast(stack_trace_string));
printf("%s\n", ToCString(stack_trace));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
