Revision: 3751
Author: [email protected]
Date: Mon Feb  1 02:29:05 2010
Log: Allow building V8 with both DEBUG and NDEBUG defined at
the same time (used from the Gyp-based build) on the
experimental issue 555 branch. This is used to build an
optimized version of V8 that runs with assertions enabled.
Review URL: http://codereview.chromium.org/551228
http://code.google.com/p/v8/source/detail?r=3751

Modified:
 /branches/experimental/issue555/src/v8.h

=======================================
--- /branches/experimental/issue555/src/v8.h    Wed Nov 18 06:12:51 2009
+++ /branches/experimental/issue555/src/v8.h    Mon Feb  1 02:29:05 2010
@@ -32,18 +32,15 @@
 #ifndef V8_V8_H_
 #define V8_V8_H_

-#if defined(GOOGLE3)
-// Google3 special flag handling.
 #if defined(DEBUG) && defined(NDEBUG)
-// If both are defined in Google3, then we are building an optimized v8 with
+// If both are defined then we are building an optimized v8 with
 // assertions enabled.
 #undef NDEBUG
 #elif !defined(DEBUG) && !defined(NDEBUG)
-// If neither is defined in Google3, then we are building a debug v8. Mark it
-// as such.
+// If neither is defined then we default to building a debug v8. Mark
+// it as such.
 #define DEBUG
 #endif
-#endif  // defined(GOOGLE3)

 // V8 only uses DEBUG, but included external files
 // may use NDEBUG - make sure they are consistent.

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to