Revision: 3754
Author: [email protected]
Date: Mon Feb 1 03:07:41 2010
Log: Remove StoreIC::Generate, and inline StoreIC::GenerateInitialize.
Review URL: http://codereview.chromium.org/558067
http://code.google.com/p/v8/source/detail?r=3754
Modified:
/branches/bleeding_edge/src/arm/ic-arm.cc
/branches/bleeding_edge/src/ia32/ic-ia32.cc
/branches/bleeding_edge/src/ic.cc
/branches/bleeding_edge/src/ic.h
/branches/bleeding_edge/src/x64/ic-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/ic-arm.cc Thu Jan 28 04:41:27 2010
+++ /branches/bleeding_edge/src/arm/ic-arm.cc Mon Feb 1 03:07:41 2010
@@ -810,7 +810,7 @@
StubCache::GenerateProbe(masm, flags, r1, r2, r3, no_reg);
// Cache miss: Jump to runtime.
- Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
+ GenerateMiss(masm);
}
@@ -831,7 +831,7 @@
}
-void StoreIC::Generate(MacroAssembler* masm, const ExternalReference& f) {
+void StoreIC::GenerateMiss(MacroAssembler* masm) {
// ----------- S t a t e -------------
// -- r0 : value
// -- r2 : name
@@ -843,7 +843,7 @@
__ stm(db_w, sp, r0.bit() | r2.bit() | r3.bit());
// Perform tail call to the entry.
- __ TailCallRuntime(f, 3, 1);
+ __ TailCallRuntime(ExternalReference(IC_Utility(kStoreIC_Miss)), 3, 1);
}
=======================================
--- /branches/bleeding_edge/src/ia32/ic-ia32.cc Mon Feb 1 00:35:38 2010
+++ /branches/bleeding_edge/src/ia32/ic-ia32.cc Mon Feb 1 03:07:41 2010
@@ -1389,7 +1389,7 @@
StubCache::GenerateProbe(masm, flags, edx, ecx, ebx, no_reg);
// Cache miss: Jump to runtime.
- Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
+ GenerateMiss(masm);
}
@@ -1413,7 +1413,7 @@
}
-void StoreIC::Generate(MacroAssembler* masm, const ExternalReference& f) {
+void StoreIC::GenerateMiss(MacroAssembler* masm) {
// ----------- S t a t e -------------
// -- eax : value
// -- ecx : name
@@ -1428,7 +1428,7 @@
__ push(ebx);
// Perform tail call to the entry.
- __ TailCallRuntime(f, 3, 1);
+ __ TailCallRuntime(ExternalReference(IC_Utility(kStoreIC_Miss)), 3, 1);
}
=======================================
--- /branches/bleeding_edge/src/ic.cc Fri Jan 29 01:52:51 2010
+++ /branches/bleeding_edge/src/ic.cc Mon Feb 1 03:07:41 2010
@@ -1393,16 +1393,6 @@
// Return the stored value.
return value;
}
-
-
-void StoreIC::GenerateInitialize(MacroAssembler* masm) {
- Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
-}
-
-
-void StoreIC::GenerateMiss(MacroAssembler* masm) {
- Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
-}
// Used from ic_<arch>.cc.
=======================================
--- /branches/bleeding_edge/src/ic.h Fri Jan 22 05:56:12 2010
+++ /branches/bleeding_edge/src/ic.h Mon Feb 1 03:07:41 2010
@@ -348,14 +348,12 @@
Handle<Object> value);
// Code generators for stub routines. Only called once at startup.
- static void GenerateInitialize(MacroAssembler* masm);
+ static void GenerateInitialize(MacroAssembler* masm) {
GenerateMiss(masm); }
static void GenerateMiss(MacroAssembler* masm);
static void GenerateMegamorphic(MacroAssembler* masm);
static void GenerateExtendStorage(MacroAssembler* masm);
private:
- static void Generate(MacroAssembler* masm, const ExternalReference& f);
-
// Update the inline cache and the global stub cache based on the
// lookup result.
void UpdateCaches(LookupResult* lookup,
=======================================
--- /branches/bleeding_edge/src/x64/ic-x64.cc Thu Jan 28 04:41:27 2010
+++ /branches/bleeding_edge/src/x64/ic-x64.cc Mon Feb 1 03:07:41 2010
@@ -1326,7 +1326,7 @@
return true;
}
-void StoreIC::Generate(MacroAssembler* masm, ExternalReference const& f) {
+void StoreIC::GenerateMiss(MacroAssembler* masm) {
// ----------- S t a t e -------------
// -- rax : value
// -- rcx : name
@@ -1341,7 +1341,7 @@
__ push(rbx); // return address
// Perform tail call to the entry.
- __ TailCallRuntime(f, 3, 1);
+ __ TailCallRuntime(ExternalReference(IC_Utility(kStoreIC_Miss)), 3, 1);
}
void StoreIC::GenerateExtendStorage(MacroAssembler* masm) {
@@ -1379,7 +1379,7 @@
StubCache::GenerateProbe(masm, flags, rdx, rcx, rbx, no_reg);
// Cache miss: Jump to runtime.
- Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
+ GenerateMiss(masm);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
