lgtm with comments:
Please always delete old archive files. You could e.g. do a clobber like
here in
test262 (I'll refactor and extract this code at some point):
https://chromium.googlesource.com/v8/v8/+/5e5fadb7/test/test262-es6/testcfg.py#154
An update of the test suite must be cleanly revertable. We've had problems
with
test262 in the past when old archive files where lying around and a test262
update got rolled back.
https://codereview.chromium.org/1240453003/diff/1/test/simdjs/testcfg.py
File test/simdjs/testcfg.py (right):
https://codereview.chromium.org/1240453003/diff/1/test/simdjs/testcfg.py#newcode88
test/simdjs/testcfg.py:88: checked_out_revision != revision):
Please add a print statement here that logs what's happening. Helps
debugging later.
https://codereview.chromium.org/1240453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
