lgtm
Nice unit test. :)
One nitpick/suggestion: Maybe add a DCHECK for !(is_debug() &&
allow_lazy_parsing()) .... somewhere.
I guess there's a part somewhere - presumably towards the end of
CompileTopLevel
(???) - from where on we assume this invariant holds, and whichever code
path
leads there is responsible for making sure it is so. Using a DCHECK as a
gentle
reminder for future contributors might be helpful.
https://codereview.chromium.org/1247743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
