Reviewers: jarin, Michael Starzinger,
Message:
ptal
this CL uses the fancy new HAdd and migrates on-heap typed arrays to the new
unified layout.
Instead of hard-coding the offset from the FixedTypedArrayBase to the start
of
the data (in elements-kinds.cc), it's now stored as an external reference
in the
object.
I had to remove a bunch of DCHECKs() that a fixed typed array element
access is
done via a tagged pointer (because it's now via the result of the HAdd
which is
an external pointer).
I also had to modify StoreNamedField to allow for storing a constant
external
reference.
Description:
Store offset between fixed typed array base and data start in object
The layout of fixed typed array base is then capable of handling
external typed arrays as well. In a follow-up CL, I'll delete external
typed arrays, and use fixed typed array base instead
BUG=v8:3996
[email protected],[email protected]
LOG=n
Please review this at https://codereview.chromium.org/1248483007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+107, -59 lines):
M src/arm/lithium-arm.cc
M src/arm64/lithium-arm64.cc
M src/assembler.h
M src/assembler.cc
M src/elements-kind.cc
M src/heap/heap.cc
M src/hydrogen.cc
M src/hydrogen-instructions.h
M src/ia32/lithium-codegen-ia32.cc
M src/ia32/lithium-ia32.cc
M src/mips/lithium-mips.cc
M src/mips64/lithium-mips64.cc
M src/objects.h
M src/objects-inl.h
M src/ppc/lithium-ppc.cc
M src/x64/lithium-codegen-x64.h
M src/x64/lithium-codegen-x64.cc
M src/x64/lithium-x64.cc
M src/x87/lithium-codegen-x87.cc
M src/x87/lithium-x87.cc
M tools/external-reference-check.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
