lgtm. Oh boy, this is ugly.
At this point, can't we just use a standard lock + condition variable
mechanism
to protect and wait for the page's sweeping status? Would it be too slow?
E.g.,
in Heap::CanMoveObjectStart we would have to lock inside the
SweepingCompleted
check.
This funky combination of lock + atomic variable seems to be quite subtle.
E.g.,
I do not like that WaitUntilSweepingCompleted only works if you know that
sweeping has started, otherwise you might be surprised. Perhaps you could
add a
comment to WaitUntilSweepingCompleted that documents the proper usage?
https://codereview.chromium.org/1244353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
