lgtm with bunch of questions.
https://codereview.chromium.org/1252623003/diff/20001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1252623003/diff/20001/src/d8.cc#newcode338
src/d8.cc:338: options.set_script_executed(true);
It looks like the set_script_executed could be calculated from the
command line arguments: script_executed is true if there is an argument
not prefixed with '-' or if there is an '-e' argument. Perhaps we could
just do a walk over the arguments (basically cut-down version of
SourceGroup::Execute) rather than the Atomic hackery?
https://codereview.chromium.org/1252623003/diff/20001/src/d8.cc#newcode2554
src/d8.cc:2554: options.set_last_run(i == stress_runs - 1);
I am a bit confused about how this can be run in parallel with anything.
I thought that everything should be stopped at this point, no?
https://codereview.chromium.org/1252623003/diff/20001/src/d8.cc#newcode2564
src/d8.cc:2564: options.set_last_run(i == stress_runs - 1);
Same here.
https://codereview.chromium.org/1252623003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
