Reviewers: Michael Starzinger, Yang,
Message:
PTAL
Description:
Unify "runtime-style" IC functions with Runtime intrinsics
Previous to this CL, ICs used a slightly different code idiom
to get to C++ code from generated code than runtime intrinsics,
using an IC_Utility class that in essence provided exactly
the same functionality as Runtime::FunctionForId, but in its
own quirky way.
This CL unifies the two mechanisms, folding IC_Utility
away by making all IC entry points in C++ code, e.g. IC
miss handlers, full-fledged runtime intrinsics. This makes
it possible to eliminate a bunch of ad-hoc declarations and
adapters that the IC system had to needlessly re-invent.
As a bonus and the original reason for this yak-shave:
IC-related C++ runtime functions are now callable from
TurboFan.
Please review this at https://codereview.chromium.org/1248303002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+312, -337 lines):
M src/arguments.h
M src/arm/code-stubs-arm.cc
M src/arm/debug-arm.cc
M src/arm/macro-assembler-arm.cc
M src/arm64/code-stubs-arm64.cc
M src/arm64/debug-arm64.cc
M src/arm64/macro-assembler-arm64.cc
M src/assembler.h
M src/assembler.cc
M src/code-stubs.cc
M src/compiler/ast-graph-builder.cc
M src/debug.h
M src/debug.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/debug-ia32.cc
M src/ia32/macro-assembler-ia32.cc
M src/ic/arm/handler-compiler-arm.cc
M src/ic/arm/ic-arm.cc
M src/ic/arm64/handler-compiler-arm64.cc
M src/ic/arm64/ic-arm64.cc
M src/ic/ia32/handler-compiler-ia32.cc
M src/ic/ia32/ic-ia32.cc
M src/ic/ic.h
M src/ic/ic.cc
M src/ic/mips/handler-compiler-mips.cc
M src/ic/mips/ic-mips.cc
M src/ic/mips64/handler-compiler-mips64.cc
M src/ic/mips64/ic-mips64.cc
M src/ic/x64/handler-compiler-x64.cc
M src/ic/x64/ic-x64.cc
M src/mips/code-stubs-mips.cc
M src/mips/debug-mips.cc
M src/mips/macro-assembler-mips.cc
M src/mips64/code-stubs-mips64.cc
M src/mips64/debug-mips64.cc
M src/mips64/macro-assembler-mips64.cc
M src/ppc/macro-assembler-ppc.cc
M src/runtime/runtime.h
M src/runtime/runtime-debug.cc
M src/snapshot/serialize.cc
M src/x64/code-stubs-x64.cc
M src/x64/debug-x64.cc
M src/x64/macro-assembler-x64.cc
M src/x87/macro-assembler-x87.cc
M test/mjsunit/regress/regress-119429.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
