lgtm On Thu, Jul 23, 2015, 21:27 [email protected] via codereview.chromium.org < [email protected]> wrote:
> Reviewers: Yang, > > Message: > Committed patchset #1 (id:1) manually as > dfd811514324a49880fdd2630ba4cac9c0b688ac (presubmit successful). > > Description: > Fix d8 prompt after readline removal > > [email protected] > > Committed: > > https://chromium.googlesource.com/v8/v8/+/dfd811514324a49880fdd2630ba4cac9c0b688ac > > Please review this at https://codereview.chromium.org/1246983004/ > > Base URL: https://chromium.googlesource.com/v8/v8.git@master > > Affected files (+1, -1 lines): > M src/d8.cc > > > Index: src/d8.cc > diff --git a/src/d8.cc b/src/d8.cc > index > > 52df5c035d38ed9d4fc42049720313f9edfd0010..9aeac11bb0a439b59a8933a6b15cdc8f0ac1116f > 100644 > --- a/src/d8.cc > +++ b/src/d8.cc > @@ -1391,7 +1391,7 @@ void Shell::RunShell(Isolate* isolate) { > printf("V8 version %s\n", V8::GetVersion()); > while (true) { > HandleScope inner_scope(isolate); > - printf(" d8>"); > + printf("d8> "); > #if defined(__native_client__) > // Native Client libc is used to being embedded in Chrome and > // has trouble recognizing when to flush. > > > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
