Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Eliminate redundant descriptor ElementTransitionAndStoreDescriptor.
port 26ffee2c718308bb85be072ed32479e4aa8e7e6b (r29789).
original commit message:
It's just the same as StoreTransitionDescriptor.
BUG=
Please review this at https://codereview.chromium.org/1253573004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -7 lines):
M src/ic/x87/access-compiler-x87.cc
M src/ic/x87/ic-compiler-x87.cc
M src/x87/interface-descriptors-x87.cc
Index: src/ic/x87/access-compiler-x87.cc
diff --git a/src/ic/x87/access-compiler-x87.cc
b/src/ic/x87/access-compiler-x87.cc
index
d5fde5d4b857e83e9f21989bef704aa324f55be3..fd2d784fdecab6041aa0912a7d41040e800fd07d
100644
--- a/src/ic/x87/access-compiler-x87.cc
+++ b/src/ic/x87/access-compiler-x87.cc
@@ -32,7 +32,7 @@ Register*
PropertyAccessCompiler::store_calling_convention() {
// receiver, name, scratch1, scratch2, scratch3.
Register receiver = StoreDescriptor::ReceiverRegister();
Register name = StoreDescriptor::NameRegister();
- DCHECK(ebx.is(ElementTransitionAndStoreDescriptor::MapRegister()));
+ DCHECK(ebx.is(StoreTransitionDescriptor::MapRegister()));
static Register registers[] = {receiver, name, ebx, edi, no_reg};
return registers;
}
Index: src/ic/x87/ic-compiler-x87.cc
diff --git a/src/ic/x87/ic-compiler-x87.cc b/src/ic/x87/ic-compiler-x87.cc
index
3697708037740dfad2400ace3da3d2ebe43c4b35..69ca69cc25f7aa393bf9dfaeffde089610385ed9
100644
--- a/src/ic/x87/ic-compiler-x87.cc
+++ b/src/ic/x87/ic-compiler-x87.cc
@@ -69,7 +69,7 @@ Handle<Code>
PropertyICCompiler::CompilePolymorphic(MapHandleList* maps,
// Polymorphic keyed stores may use the map register
Register map_reg = scratch1();
DCHECK(kind() != Code::KEYED_STORE_IC ||
- map_reg.is(ElementTransitionAndStoreDescriptor::MapRegister()));
+ map_reg.is(StoreTransitionDescriptor::MapRegister()));
__ mov(map_reg, FieldOperand(receiver(), HeapObject::kMapOffset));
int receiver_count = maps->length();
int number_of_handled_maps = 0;
Index: src/x87/interface-descriptors-x87.cc
diff --git a/src/x87/interface-descriptors-x87.cc
b/src/x87/interface-descriptors-x87.cc
index
279b42677c1e84cf0b09561935a05ff3508313cd..333564e09995afffc834146186bd7a14b4567cf8
100644
--- a/src/x87/interface-descriptors-x87.cc
+++ b/src/x87/interface-descriptors-x87.cc
@@ -46,11 +46,6 @@ const Register
StoreGlobalViaContextDescriptor::NameRegister() { return ecx; }
const Register StoreGlobalViaContextDescriptor::ValueRegister() { return
eax; }
-const Register ElementTransitionAndStoreDescriptor::MapRegister() {
- return ebx;
-}
-
-
const Register InstanceofDescriptor::left() { return eax; }
const Register InstanceofDescriptor::right() { return edx; }
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
