This is definitely getting there. Maybe we should have some tests in test-api that at least documents how this interact with interceptors as well?
http://codereview.chromium.org/555149/diff/5002/6005 File src/runtime.cc (right): http://codereview.chromium.org/555149/diff/5002/6005#newcode601 src/runtime.cc:601: // and API defined callback. and -> an http://codereview.chromium.org/555149/diff/5002/6005#newcode2907 src/runtime.cc:2907: if (result.type() == FIELD || result.type() == NORMAL ) How about CONSTANT_FUNCTION? Is CALLBACK handled correctly if there already is a CALLBACK property? http://codereview.chromium.org/555149/diff/5002/6005#newcode2944 src/runtime.cc:2944: return Runtime::ForceSetObjectProperty(js_object, name, obj_value, attr); Did you need the ForceSet here? http://codereview.chromium.org/555149/diff/5002/6008 File test/cctest/test-api.cc (right): http://codereview.chromium.org/555149/diff/5002/6008#newcode2308 test/cctest/test-api.cc:2308: Local<Script> script_desc = Script::Compile(v8_str("var prop =" You could give yourself a bit more horizontal space by doing: Local<Script> script_desc = Script::Compile(v8_str("..." "...")); http://codereview.chromium.org/555149/diff/5002/6008#newcode2316 test/cctest/test-api.cc:2316: Local<Script> script_define = Move '=' to next line and do a four-space indent. Repeated below. http://codereview.chromium.org/555149/diff/5002/6008#newcode2317 test/cctest/test-api.cc:2317: Script::Compile(v8_str("var desc = {get: function(){return 42; }," Space before "get:". Repeated below. http://codereview.chromium.org/555149 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
