NOT LGTM. This change is not correct, because the stack pointer is not
constant
across a function (at the instruction level). We currently have explicit
Push
operations there, and we might have other things in the future. Plus we are
still not sure whether LoadStackPointer should also be effectful.
Personally I'd also consider this change bad wrt. product excellence
strategy,
because it's a lot of complexity for no real benefit (I'd guess that even
in the
hottest paths, this only gives you up to 5% if at all).
https://codereview.chromium.org/1242303005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
