[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeurer@chromium.org)

[ishell]

On 2015/07/24 08:45:21, Benedikt Meurer wrote:
Hey MIPS people,

Can you look into the failures? As far as I can tell, we need at least

diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc
index 272feda..352289a 100644
--- a/src/mips/code-stubs-mips.cc
+++ b/src/mips/code-stubs-mips.cc
@@ -5298,8 +5298,7 @@ void  
LoadGlobalViaContextStub::Generate(MacroAssembler*
masm) {
    // Fallback to the runtime.
    __ bind(&slow_case);
    __ SmiTag(slot_reg);
-  __ Drop(1);  // Pop return address.
-  __ Push(slot_reg, name_reg, result_reg);
+  __ Push(slot_reg, name_reg);
    __ TailCallRuntime(Runtime::kLoadGlobalViaContext, 2, 1);
  }

@@ -5410,8 +5409,7 @@ void  
StoreGlobalViaContextStub::Generate(MacroAssembler*
masm) {
    // Fallback to the runtime.
    __ bind(&slow_case);
    __ SmiTag(slot_reg);
-  __ Drop(1);  // Pop return address.
-  __ Push(slot_reg, name_reg, value_reg, cell_reg);
+  __ Push(slot_reg, name_reg, value_reg);
    __ TailCallRuntime(is_strict(language_mode())
                           ? Runtime::kStoreGlobalViaContext_Strict
                           : Runtime::kStoreGlobalViaContext_Sloppy,

but then there are still failures left, which I'm not sure about.

Please take a look.

Thanks,
Benedikt

Added comments about MIPS ports here:
https://codereview.chromium.org/1238143002/

https://codereview.chromium.org/1254723004/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.