https://codereview.chromium.org/1252303002/diff/20001/src/compiler/js-generic-lowering.cc
File src/compiler/js-generic-lowering.cc (right):
https://codereview.chromium.org/1252303002/diff/20001/src/compiler/js-generic-lowering.cc#newcode362
src/compiler/js-generic-lowering.cc:362: InlineCacheState state =
FLAG_vector_stores && p.feedback().index() == -1
Can we restructure this a little to be more readable. I had a hard time
understanding it and would have come to the wrong conclusion without
your offline help. How about this ...
// We have a special case where we do keyed stores but don't have a type
// feedback vector slot allocated to support it. In this case, install
// the megamorphic keyed store stub which needs neither vector nor slot.
bool use_vector_slot = FLAG_vector_stores && p.feedback().index() != -1;
Callable callable = CodeFactory::KeyedStoreICInOptimizedCode(isolate(),
language_mode, use_vector_slot ? UNINITIALIZED : MEGAMORPHIC);
if (use_vector_slot) {
node->InsertInput(zone(), 3,
jsgraph()->SmiConstant(p.feedback().index()));
} else {
node->RemoveInput(3);
}
https://codereview.chromium.org/1252303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
