Reviewers: jochen,
Description:
Remove old TODO and commented-out DCHECK in Isolate::RunMicrotasks
Per discussion on the bug, the DCHECK'd case actually occurs in normal
operation, outside of V8's control.
BUG=chromium:388244
Please review this at https://codereview.chromium.org/1255043002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -7 lines):
M src/isolate.cc
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index
5400feae77c8f7e215af99b9f3f9942ecb133dc6..15b16fc5df084860991c45cede3574d5a23c9985
100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2653,13 +2653,6 @@ void Isolate::EnqueueMicrotask(Handle<Object>
microtask) {
void Isolate::RunMicrotasks() {
- // %RunMicrotasks may be called in mjsunit tests, which violates
- // this assertion, hence the check for --allow-natives-syntax.
- // TODO(adamk): However, this also fails some layout tests.
- //
- // DCHECK(FLAG_allow_natives_syntax ||
- // handle_scope_implementer()->CallDepthIsZero());
-
// Increase call depth to prevent recursive callbacks.
v8::Isolate::SuppressMicrotaskExecutionScope suppress(
reinterpret_cast<v8::Isolate*>(this));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
