lgtm % nits
https://codereview.chromium.org/1254003004/diff/1/test/mjsunit/harmony/block-scope-class.js
File test/mjsunit/harmony/block-scope-class.js (right):
https://codereview.chromium.org/1254003004/diff/1/test/mjsunit/harmony/block-scope-class.js#newcode7
test/mjsunit/harmony/block-scope-class.js:7: // Flags: --no-legacy-const
--harmony-sloppy
What does legacy const have to do with it? I see no uses of 'const' in
this test.
https://codereview.chromium.org/1254003004/diff/1/test/mjsunit/harmony/block-scope-class.js#newcode13
test/mjsunit/harmony/block-scope-class.js:13: assertEquals(value,
eval("(function() { 'use strict'; var x = 0; {" + code + "} })()"));
Please wrap to 80 chars here and elsewhere in this file (sad we don't
have a lint for this).
https://codereview.chromium.org/1254003004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
