Reviewers: Jakob,
Message:
PTAL
https://codereview.chromium.org/1245623005/diff/40001/test/benchmarks/testcfg.py
File test/benchmarks/testcfg.py (left):
https://codereview.chromium.org/1245623005/diff/40001/test/benchmarks/testcfg.py#oldcode189
test/benchmarks/testcfg.py:189: return [[], ["--turbo"]]
This completely ignored the status file. The new approach will e.g.
allow to limit a single benchmark to no-variants in the status file.
https://codereview.chromium.org/1245623005/diff/40001/test/preparser/testcfg.py
File test/preparser/testcfg.py (right):
https://codereview.chromium.org/1245623005/diff/40001/test/preparser/testcfg.py#newcode130
test/preparser/testcfg.py:130: return lambda _:
testsuite.DEFAULT_VARIANT
Here, status file filtering is ignored as it doesn't make much sense
with only the default variant.
https://codereview.chromium.org/1245623005/diff/40001/test/test262-es6/testcfg.py
File test/test262-es6/testcfg.py (right):
https://codereview.chromium.org/1245623005/diff/40001/test/test262-es6/testcfg.py#newcode74
test/test262-es6/testcfg.py:74:
This precomputes the variants, so that on iteration over the tests, no
lists have to be generated.
https://codereview.chromium.org/1245623005/diff/40001/test/test262-es6/testcfg.py#newcode99
test/test262-es6/testcfg.py:99: return variants.both
Minor drawback: In the both-case, also after this patch it won't be
possible to only rerun the exact test call. You'll be able to rerun the
variant name, e.g. turbofan and the test runner will execute a nostrict
and strict run.
I thought about generalizing also nostrict and strict as named variants
that can be combined with the others, but ran into too many potential
test-runner slow-down and over-design.
Description:
[test] Key variant flags by variant name everywhere.
This allows variants to be named on test failures (follow
up) and then to be used in the test runner for a repro.
This also speeds up variant iteration for test262 and fixes
a bug with variants for benchmarks.
BUG=chromium:511215
LOG=n
Please review this at https://codereview.chromium.org/1245623005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+152, -44 lines):
M test/benchmarks/testcfg.py
M test/preparser/testcfg.py
M test/test262-es6/testcfg.py
M tools/run-tests.py
M tools/testrunner/local/testsuite.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
