Wouldn't the following design simplify things:
- let each test suite provide a default list of named variants (just the
names,
not the corresponding flag lists)
- let the command-line args filter those default variants as needed
- let each test case, by means of the status file, further filter the
variants
for that test as needed
- once the list of variant names per test has been computed, have a
translation
step that translates them to a list of lists of flags. This translation
could
again be implemented per-testsuite to keep custom variant definitions
local.
Yea I thought about something like that. The question is, do we want to make
suite-custom variant names public in the overall runner?
E.g. a turbofan variant with [--turbo, --always-opt], and a plain-turbofan
variant with [--turbo]. Similar e.g. default_nostrict and default_strict
etc?
The last bit of your suggestion might cost a little performance on test262
if
e.g. the nostrict and strict variant flags are computed for each test case
(not
more than currently though).
https://codereview.chromium.org/1245623005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
