LGTM, but:
http://codereview.chromium.org/566016/diff/3001/4001 File test/mjsunit/regress/regress-crbug-3867.js (right): http://codereview.chromium.org/566016/diff/3001/4001#newcode1 test/mjsunit/regress/regress-crbug-3867.js:1: // Copyright 2010 the V8 project authors. All rights reserved. Make sure this isn't executable. http://codereview.chromium.org/566016/diff/3001/4001#newcode41 test/mjsunit/regress/regress-crbug-3867.js:41: assertArrayEquals(["s1", "s2", "s3"], props({s1: 0, s2: 0, s3: 0})); It would be great with a test where the property names aren't sorted to make sure that it's really the insertion order that matters for named properties. http://codereview.chromium.org/566016 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
