Thanks! Didn't investigate just yet the test failures, should be first thing tomorrow.
The change in runtime-internal isn't intended, I'll cleanup once I get green in the lab. On Mon, Jul 27, 2015 at 9:57 PM <[email protected]> wrote: > The general direction seems good. Did you investigate the test failures > already? > > > > https://codereview.chromium.org/1242123006/diff/80001/src/compiler/register-allocator.cc > File src/compiler/register-allocator.cc (right): > > > https://codereview.chromium.org/1242123006/diff/80001/src/compiler/register-allocator.cc#newcode475 > src/compiler/register-allocator.cc:475 > <https://codereview.chromium.org/1242123006/diff/80001/src/compiler/register-allocator.cc#newcode475src/compiler/register-allocator.cc:475>: > UsePosition* > LiveRange::NextStackPosition(LifetimePosition start) const { > Nit: I'd use NextSlotPosition as name for consistency (use type is > kRequiresSlot). > > > https://codereview.chromium.org/1242123006/diff/80001/src/runtime/runtime-internal.cc > File src/runtime/runtime-internal.cc (right): > > > https://codereview.chromium.org/1242123006/diff/80001/src/runtime/runtime-internal.cc#newcode29 > src/runtime/runtime-internal.cc:29 > <https://codereview.chromium.org/1242123006/diff/80001/src/runtime/runtime-internal.cc#newcode29src/runtime/runtime-internal.cc:29>: > Object* ret = > isolate->Throw(args[0]); > What is the motivation for this change? > > https://codereview.chromium.org/1242123006/ > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
