On 2015/07/28 14:26:27, paul.l... wrote:
patchset 2 lgtm.
But a couple nits in commit message: title should remove the word 'test',
since
you fixed disasm itself, and TEST should show the actual failing test:
TEST=cctest/test-disasm-mips[64]/Type3
There are two specific tests:
TEST=cctest/test-disasm-mips/Type0,
cctest/test-disasm-mips64/Type3
https://codereview.chromium.org/1258743004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
