Please re-review. It actually works now. And is called.
http://codereview.chromium.org/552186/diff/3001/3003 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/552186/diff/3001/3003#newcode6797 src/arm/codegen-arm.cc:6797: bool ascii) { I'll see how artificial I can make it. http://codereview.chromium.org/552186/diff/3001/3003#newcode6834 src/arm/codegen-arm.cc:6834: if (FLAG_debug_code) { Not understood. FLAG_debug_code is off by default in debug mode too. I'll remove this, because all it really tests is that the previous code does what it's supposed to do. http://codereview.chromium.org/552186/diff/3001/3003#newcode6994 src/arm/codegen-arm.cc:6994: __ cmp(r1, Operand(static_cast<int32_t>(kSeqStringTag | kTwoByteStringTag))); Rewritten completely. http://codereview.chromium.org/552186/diff/3001/3005 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/552186/diff/3001/3005#newcode940 src/arm/macro-assembler-arm.cc:940: add(scratch1, length, Operand(kObjectAlignmentMask)); Nope, better coders. Stack alignment was off, so the wrong argument was read ... and it was never a string. I.e., we hit the runtime system every time. http://codereview.chromium.org/552186/diff/3001/3005#newcode952 src/arm/macro-assembler-arm.cc:952: mov(scratch1, Operand(Factory::ascii_string_map())); Fixed. Along with all the ASCII's. http://codereview.chromium.org/552186 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
