LGTM.
http://codereview.chromium.org/569010/diff/1/10 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/569010/diff/1/10#newcode179 src/arm/codegen-arm.cc:179: if (strlen(FLAG_stop_at) > 0 && This should probably be lifted outside the if. http://codereview.chromium.org/569010/diff/1/9 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/569010/diff/1/9#newcode114 src/arm/fast-codegen-arm.cc:114: __ add(fp, sp, Operand(2 * kPointerSize)); Thanks. http://codereview.chromium.org/569010/diff/1/8 File src/fast-codegen.cc (right): http://codereview.chromium.org/569010/diff/1/8#newcode33 src/fast-codegen.cc:33: #include "codegen.h" I'm surprised you need both codegen.h and codegen-inl.h. http://codereview.chromium.org/569010 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
