One nit. Looks okay otherwise. LGTM.

"Apparently in a test involving eval, strict mode and const, we
don't produce the same code on recompile..."

Always eval/strict... :p Thanks for finding that, it will be seriously helpful
to fix.
--Michael


https://codereview.chromium.org/1269733002/diff/1/src/full-codegen/ia32/full-codegen-ia32.cc
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1269733002/diff/1/src/full-codegen/ia32/full-codegen-ia32.cc#newcode2657
src/full-codegen/ia32/full-codegen-ia32.cc:2657: printf("let ");
This should go, right?

https://codereview.chromium.org/1269733002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to